Adds dap #792
Merged
Adds dap #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
Adds DAP to site
_includes/scripts.html
Outdated
| <script src="{{ site.baseurl }}/assets/js/styleguide.js"></script> | ||
| <script async id="_fed_an_ua_tag" src="https://dap.digitalgov.gov/Universal-Federated-Analytics-Min.js?agency=DOC&subagency=CEN" type="text/javascript"></script> |
There was a problem hiding this comment.
I think this should be moved to head.html so that it's loaded within the head HTML tags.
There was a problem hiding this comment.
@curt-mitch-census I think I fixed this issue and would appreciate input!
There was a problem hiding this comment.
@sadiejay Sorry, I should have been more specific: you were right to move the DAP script to the head.html, according to their suggested documentation. However, I think you can keep the styleguide.js file within the scripts.html file along with the uswds.min.js file to keep the non-analytics JavaScript files in one place. My apologies for the mixup!
sadiejay
commented
Mar 21, 2024
There was a problem hiding this comment.
@curt-mitch-census
Thank you for catching this! Will move these to head!
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
Co-authored-by: Curtis Mitchell <[email protected]>
curt-mitch-census
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.