Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show selected persons on report view #892

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Conversation

bseber
Copy link
Contributor

@bseber bseber commented Oct 20, 2024

closes #903

Here are some things you should have thought about:

Multi-Tenancy

  • [ ] Extended new entities with AbstractTenantAwareEntity?
  • [ ] New entity added to TenantAwareDatabaseConfiguration?
  • [ ] Tested with dev-multitenant profile?

@derTobsch derTobsch added this to the 2.11.0 milestone Oct 22, 2024
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Oct 22, 2024
@derTobsch derTobsch force-pushed the report-show-selected-persons branch 2 times, most recently from 0cf4e16 to b830c9b Compare October 25, 2024 07:24
@bseber bseber force-pushed the report-show-selected-persons branch from b830c9b to f95abd1 Compare October 25, 2024 09:45
@bseber bseber marked this pull request as ready for review October 25, 2024 10:21
@bseber
Copy link
Contributor Author

bseber commented Oct 25, 2024

js bundle size:

vorher:

.rw-r--r--@  35k user-common.js
im browser: 10.4kb gzipped

nachher: (mit tooltip / popper)

.rw-r--r--@  95k user-common.js
im browser: 24.8kb gzipped

das sind 14.4kb mehr. wo kommen die her und kriegen wir das noch kleiner?
popper an sich hat laut bundlephobia 7.3kB minified + gzipped.

vielleicht ist das aber auch in Ordnung so... 😅

@bseber bseber force-pushed the report-show-selected-persons branch from 3bc8acb to 27ce3a5 Compare October 25, 2024 12:05
@bseber bseber force-pushed the report-show-selected-persons branch from 27ce3a5 to c61d93c Compare October 25, 2024 12:07
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
64.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@derTobsch derTobsch merged commit 94c8ab9 into main Oct 25, 2024
2 of 3 checks passed
@derTobsch derTobsch deleted the report-show-selected-persons branch October 25, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Berichte: Zeige ausgewählte Personen
2 participants