Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle portal user lifecycle #546

Merged
merged 14 commits into from
Jun 28, 2024
Merged

handle portal user lifecycle #546

merged 14 commits into from
Jun 28, 2024

Conversation

grafjo
Copy link
Contributor

@grafjo grafjo commented Jan 17, 2024 •
edited
Loading

Here are some things you should have thought about:

Multi-Tenancy

  • Extended new entities with AbstractTenantAwareEntity?
  • New entity added to TenantAwareDatabaseConfiguration?
  • Tested with dev-multitenant profile?

TODOs:

  • make TenantUserEntity.firstLoginAt / TenantUserEntity.lastLoginAt optional
  • introduce status field to TenantUserEntity (e.g. enabled/disabled/deleted)
  • add timestamp field for each possible status of TenantUserEntity

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@github-actions github-actions bot added the Stale label Mar 18, 2024
@github-actions github-actions bot closed this Mar 25, 2024
@derTobsch derTobsch added this to the General Backlog milestone Mar 25, 2024
@derTobsch derTobsch reopened this Mar 25, 2024
@derTobsch derTobsch removed the Stale label Mar 25, 2024
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Mar 25, 2024
@derTobsch derTobsch force-pushed the feature/handle-portal-user-lifecycle branch from 014e68d to 470c775 Compare March 25, 2024 07:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
6.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@derTobsch derTobsch force-pushed the feature/handle-portal-user-lifecycle branch from 470c775 to 4124ca4 Compare May 24, 2024 11:35
@grafjo grafjo force-pushed the feature/handle-portal-user-lifecycle branch 2 times, most recently from 3e6a881 to 047e02b Compare June 15, 2024 19:27
@grafjo grafjo marked this pull request as ready for review June 15, 2024 19:27
@grafjo grafjo requested review from bseber and derTobsch June 15, 2024 19:28
@grafjo grafjo self-assigned this Jun 15, 2024
@grafjo grafjo force-pushed the feature/handle-portal-user-lifecycle branch 2 times, most recently from fa3f5db to 39af8eb Compare June 16, 2024 13:18
@bseber bseber force-pushed the feature/handle-portal-user-lifecycle branch from 39af8eb to 9d53845 Compare June 21, 2024 13:13
@grafjo grafjo force-pushed the feature/handle-portal-user-lifecycle branch from 9d53845 to f98577d Compare June 21, 2024 14:37
@bseber bseber force-pushed the feature/handle-portal-user-lifecycle branch from f8ea41f to 4be6eef Compare June 26, 2024 19:01
@bseber bseber force-pushed the feature/handle-portal-user-lifecycle branch 2 times, most recently from 04376b2 to 6d5df4d Compare June 26, 2024 19:59
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Jun 28, 2024
@bseber bseber force-pushed the feature/handle-portal-user-lifecycle branch from 6d5df4d to 45d69c7 Compare June 28, 2024 07:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@bseber bseber merged commit 115bd24 into main Jun 28, 2024
1 of 2 checks passed
@bseber bseber deleted the feature/handle-portal-user-lifecycle branch June 28, 2024 08:07
@bseber bseber mentioned this pull request Jul 5, 2024
Merged
2 tasks
derTobsch added a commit that referenced this pull request Jul 5, 2024
@derTobsch
fix authentication session reloader with tenantid context (#758)
89eafc4 
Updating user permissions is handled by
`ReloadAuthenticationAuthoritiesFilter` on next request so the user has
not to logout and login again. This action has to run with tenant
context, too now since
#546

Here are some things you should have thought about:

**Multi-Tenancy**
- ~~[ ] Extended new entities with `AbstractTenantAwareEntity`?~~
- [x] New entity added to `TenantAwareDatabaseConfiguration`?
- [x] Tested with `dev-multitenant` profile?

<!--

Thanks for contributing to the zeiterfassung.
Please review the following notes before submitting you pull request.

Please look for other issues or pull requests which already work on this
topic. Is somebody already on it? Do you need to synchronize?

# Security Vulnerabilities

🛑 STOP! 🛑 If your contribution fixes a security vulnerability, please do
not submit it.
Instead, please write an E-Mail to [email protected] with all the
information
to recreate the security vulnerability.

# Describing Your Changes

If, having reviewed the notes above, you're ready to submit your pull
request, please
provide a brief description of the proposed changes.

If they:
🐞 fix a bug, please describe the broken behaviour and how the changes
fix it.
    Please label with 'type: bug' and 'status: new'
    
🎁 make an enhancement, please describe the new functionality and why you
believe it's useful.
    Please label with 'type: enhancement' and 'status: new'
 
If your pull request relates to any existing issues,
please reference them by using the issue number prefixed with #.

-->
@derTobsch derTobsch modified the milestones: 2.7.0, 2.6.2 Jul 5, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bseber bseber bseber approved these changes

@derTobsch derTobsch Awaiting requested review from derTobsch

Assignees

@grafjo grafjo

Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot.
Projects
None yet
Milestone
2.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@grafjo @bseber @derTobsch