Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TenantAwareDataSource statt AdminAwareDataSource für fachliche Events nutzen #690

Closed
honnel opened this issue May 10, 2024 · 0 comments · Fixed by #722
Closed

TenantAwareDataSource statt AdminAwareDataSource für fachliche Events nutzen #690

honnel opened this issue May 10, 2024 · 0 comments · Fixed by #722
Assignees
@grafjo
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. topic: security type: bug
Milestone
2.6.1

Comments

@honnel
Copy link
Contributor

honnel commented May 10, 2024

Aktuell nutzen wir die AdminAwareDataSource für

  • ApplicationAbsenceWriteEntity
  • AbsenceTypeEntity

Hier wollen wir auf eine TenantAwareDataSource umstellen, sodass wie auch für Web Requests die TenantId auf Datenbank-Ebene checken.

AK:

  • Es gibt kein Repository mehr, das ein ByTenant enthält bzw. auf einer AdminAware-Entity nutzt

Erster Ansatz: #460
@honnel honnel added this to the General Backlog milestone May 10, 2024
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label May 10, 2024
@honnel honnel added type: enhancement A general enhancement type: security security issues topic: security and removed type: security security issues labels May 10, 2024
@grafjo grafjo self-assigned this Jun 14, 2024
@grafjo grafjo mentioned this issue Jun 14, 2024
Merged
3 tasks
@derTobsch derTobsch modified the milestones: General Backlog, 2.7.0 Jun 14, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Jun 14, 2024
@derTobsch derTobsch modified the milestones: 2.7.0, 2.6.1 Jun 14, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. labels Jun 14, 2024
@derTobsch derTobsch added status: planned This issue is planned in a milestone and won't be touched by stale bot. type: bug and removed status: new Initial state for every issue / pullrequest type: enhancement A general enhancement labels Jun 14, 2024
@bseber bseber closed this as completed in 60fb89b Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grafjo grafjo

Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot. topic: security type: bug
Projects
None yet
Milestone
2.6.1
Development

Successfully merging a pull request may close this issue.

Change entities to be TenantAware urlaubsverwaltung/zeiterfassung
3 participants
@honnel @grafjo @derTobsch