Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change entities to be TenantAware #722

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Change entities to be TenantAware #722

merged 3 commits into from
Jun 21, 2024

Conversation

grafjo
Copy link
Contributor

@grafjo grafjo commented Jun 2, 2024 •
edited
Loading

will fix #690

Here are some things you should have thought about:

Multi-Tenancy

  • Extended new entities with AbstractTenantAwareEntity?
  • New entity added to TenantAwareDatabaseConfiguration?
  • Tested with dev-multitenant profile?

@grafjo grafjo marked this pull request as ready for review June 7, 2024 11:08
@grafjo grafjo changed the title Change entities be be TenantAware DRAFT: Change entities be be TenantAware Jun 7, 2024
@grafjo grafjo force-pushed the use-tenantaware branch 2 times, most recently from abeeb4f to c408835 Compare June 14, 2024 07:54
@grafjo grafjo changed the title DRAFT: Change entities be be TenantAware Change entities be be TenantAware Jun 14, 2024
@grafjo grafjo force-pushed the use-tenantaware branch 2 times, most recently from 825feab to 9ba0634 Compare June 14, 2024 08:18
@bseber bseber changed the title Change entities be be TenantAware Change entities to be TenantAware Jun 14, 2024
@grafjo grafjo force-pushed the use-tenantaware branch from 9ba0634 to d42e230 Compare June 14, 2024 10:31
@derTobsch derTobsch added this to the 2.7.0 milestone Jun 14, 2024
@github-actions github-actions bot added the status: planned This issue is planned in a milestone and won't be touched by stale bot. label Jun 14, 2024
@derTobsch derTobsch modified the milestones: 2.7.0, 2.6.1 Jun 14, 2024
@github-actions github-actions bot added status: new Initial state for every issue / pullrequest status: planned This issue is planned in a milestone and won't be touched by stale bot. and removed status: planned This issue is planned in a milestone and won't be touched by stale bot. status: new Initial state for every issue / pullrequest labels Jun 14, 2024
@grafjo grafjo requested review from bseber and derTobsch June 14, 2024 10:44
@grafjo grafjo force-pushed the use-tenantaware branch 7 times, most recently from 167cedd to ade5740 Compare June 14, 2024 17:24
@grafjo grafjo force-pushed the use-tenantaware branch from f8ee6be to 366b2ec Compare June 15, 2024 19:25
grafjo and others added 3 commits June 21, 2024 15:06
@grafjo @bseber
Refactor AbsenceTypeEntity and AbsenceWriteEntity to be TenantAware
61e7e99 
* adjust rabbitmq listeners to use tenantContextHolder
* adjust FederalStateSettingsRepository to kill findByTenantId
@bseber
do not override already provided methods
03f9aca 
CrudRepository is provided by spring data and methods are learned by developers.
@bseber
use final variables
9aa6964
@bseber bseber force-pushed the use-tenantaware branch from 97262f1 to 9aa6964 Compare June 21, 2024 13:06
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bseber bseber merged commit 60fb89b into main Jun 21, 2024
2 checks passed
@bseber bseber deleted the use-tenantaware branch June 21, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bseber bseber bseber approved these changes

@derTobsch derTobsch Awaiting requested review from derTobsch

Assignees
No one assigned
Labels
status: planned This issue is planned in a milestone and won't be touched by stale bot.
Projects
None yet
Milestone
2.6.1
Development

Successfully merging this pull request may close these issues.

TenantAwareDataSource statt AdminAwareDataSource für fachliche Events nutzen
3 participants
@grafjo @bseber @derTobsch