Skip to content

Commit

Permalink
Remove deprecated `zeiterfassung.tenant.registration.rabbitmq.routing… (
Browse files Browse the repository at this point in the history
#473)

…-key-deleted-two`

closes #472 

Here are some things you should have thought about:

**Multi-Tenancy**
- [ ] Extended new entities with `AbstractTenantAwareEntity`?
- [ ] New entity added to `TenantAwareDatabaseConfiguration`?
- [ ] Tested with `dev-multitenant` profile?

<!--

Thanks for contributing to the zeiterfassung.
Please review the following notes before submitting you pull request.

Please look for other issues or pull requests which already work on this
topic. Is somebody already on it? Do you need to synchronize?

# Security Vulnerabilities

🛑 STOP! 🛑 If your contribution fixes a security vulnerability, please do
not submit it.
Instead, please write an E-Mail to [email protected] with all the
information
to recreate the security vulnerability.

# Describing Your Changes

If, having reviewed the notes above, you're ready to submit your pull
request, please
provide a brief description of the proposed changes.

If they:
🐞 fix a bug, please describe the broken behaviour and how the changes
fix it.
    Please label with 'type: bug' and 'status: new'
    
🎁 make an enhancement, please describe the new functionality and why you
believe it's useful.
    Please label with 'type: enhancement' and 'status: new'
 
If your pull request relates to any existing issues,
please reference them by using the issue number prefixed with #.

-->
  • Loading branch information
derTobsch authored Nov 29, 2023
2 parents 1050aea + 04b0d76 commit cd4c54c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ public String getRoutingKeyDeletedTemplate() {
return routingKeyDeletedTemplate;
}

@Deprecated
public void setRoutingKeyDeletedTwo(String routingKeyDeletedTemplate) {
this.routingKeyDeletedTemplate = routingKeyDeletedTemplate;
}

public void setRoutingKeyDeletedTemplate(String routingKeyDeletedTemplate) {
this.routingKeyDeletedTemplate = routingKeyDeletedTemplate;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,6 @@ void ensureRoutingKeyCreatedTemplateCannotBeEmptyOrNull(String routingKeyCreated
assertThat(violations.size()).isOne();
}

@ParameterizedTest
@ValueSource(strings = {""})
@NullSource
void ensureRoutingKeyDeletedTwoCannotBeEmptyOrNull(String routingKeyDeletedTwo) {
final OidcClientRegistrationRabbitmqConfigurationProperties sut = new OidcClientRegistrationRabbitmqConfigurationProperties();
sut.setRoutingKeyDeletedTwo(routingKeyDeletedTwo);
final Set<ConstraintViolation<OidcClientRegistrationRabbitmqConfigurationProperties>> violations = validator.validate(sut);

assertThat(violations.size()).isOne();
}

@ParameterizedTest
@ValueSource(strings = {""})
@NullSource
Expand Down

0 comments on commit cd4c54c

Please sign in to comment.