New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS2 #31

Open

tiesus opened this issue Jul 7, 2024 · 0 comments

tiesus commented Jul 7, 2024

In the current ROS2 branch the param max_flatness_storage_ and max_elevation_treshold_ are never set. https://github.com/url-kaist/patchwork-plusplus-ros/blob/15a00dafab479fb86e25416f31ba5cccd559cfa1/include/patchworkpp/patchworkpp.hpp#L235C5-L235C55

This results in runtime errors. In think here is a line, where the default value for an undefined int causes trouble:

patchwork-plusplus-ros/include/patchworkpp/patchworkpp.hpp

Line 798 in 15a00da

int exceed_num = update_flatness_[i].size() - max_flatness_storage_;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment