-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Рожков Максим #81
base: master
Are you sure you want to change the base?
Рожков Максим #81
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Есть замечания.
Так же не хватает:
- У картинок нет подписей
- Первая буква параграфа должна быть больше все остальных
- Нет цитат
- Нет вертикального текста
index.css
Outdated
@font-face | ||
{ | ||
font-family: Parizhel; | ||
src: url(MainHeader.ttf)format('truetype'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttf не самый универсальный формат.
index.css
Outdated
|
||
html | ||
{ | ||
zoom: 150%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это зачем?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Чтобы страница лучше выглядела, не понял как сделать также, без этого свойства
index.css
Outdated
.aboutMarty | ||
{ | ||
font-size: 20px; | ||
font-family: 'Moscow Sans Regular'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Надо сделать фолбэк для шрифтов + можно записать одним свойством font-family + font-size
index.css
Outdated
|
||
.mainHeader | ||
{ | ||
font-family: 'Parizhel'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Фолбэк + односвойство
🍅 |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Есть несколько комментариев 🍅
{ | ||
font: 45px 'Parizhel', cursive; | ||
text-align: center; | ||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тоже можно унести в font
position: absolute; | ||
top: 5px; | ||
right: 5px; | ||
width: .7em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему в em?
Подсказка: попробуй найти другой способ вертикального текста
|
||
main | ||
{ | ||
margin: 1%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? Лучше сделать в px, потому что в % может работать не как ожидается
@MaximRhz Сделай пожалуйста правки |
Посмотреть решение