-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Бородин Николай #65
base: master
Are you sure you want to change the base?
Бородин Николай #65
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
Привет, я сейчас переназначу тебе ментора, это нормально |
🔔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍅
@font-face | ||
{ | ||
font-family: 'Bikham Cyr Script'; | ||
src: url(bikham-cyr-script_[allfont.ru].ttf) format(ttf); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ttf шрифты не везде работают
{ | ||
position: relative; | ||
max-width: 1200px; | ||
margin: 0 auto 4rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему решил использовать rem
?
.remark_item | ||
{ | ||
display: block; | ||
width: .3em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А здесь вдруг em
?
margin-right: 1rem; | ||
padding-bottom: .3rem; | ||
font: .8rem 'Cutive Mono', monospace; | ||
font-weight: bold; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bold
тоже можно включить в правило выше
|
||
.paper_name | ||
{ | ||
font: 70px 'Bikham Cyr Script'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А здесь вдруг px
вообще
font: italic 1.25rem 'Cutive Mono'; | ||
margin: 1.5rem; | ||
padding: .5rem; | ||
border-top: 4px double #fadabb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Здесь можно сократить
|
||
.paper_date | ||
{ | ||
font: italic 1.25rem 'Cutive Mono'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Почему нет деградации?
.entire_text | ||
{ | ||
column-count: 3; | ||
-moz-column-count: 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем нужны эти правила?
Посмотреть решение