Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ильенко Кристина #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ильенко Кристина #27

wants to merge 1 commit into from

Conversation

chrighter
Copy link

No description provided.

zanevskaya
zanevskaya requested changes May 6, 2018
View reviewed changes
Copy link
Collaborator

@zanevskaya zanevskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет!
Есть несколько замечаний:

  1. Нет проверок на все элементы (ты проверяешь все элементы по 2 раза (что является лишним действием), а "Покер" ни разу).
  2. Нет текста ошибок для негативных проверок.
  3. Не хватает проверки приграничных значений.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanevskaya zanevskaya zanevskaya requested changes

Assignees

@zanevskaya zanevskaya

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrighter @zanevskaya