-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Назарова Галина #40
base: master
Are you sure you want to change the base?
Назарова Галина #40
Conversation
🍏 Пройден линтинг и базовые тесты |
|
||
.sort-rates | ||
{ | ||
direction: rtl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А если появится еще текст?
Для него отдельно направление будешь задавать?
margin-top: 15px; | ||
} | ||
|
||
.sort-rates > .sort-rating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Названия не описывают сути. Выглядят одинаково
🍏 Пройден линтинг и базовые тесты |
🚀 |
</ul> | ||
<div class="photos flex"> | ||
<div class="photo abissinskaya"> | ||
<img src="img/Абиссинская1.jpg" alt="Абиссинская кот Гоша" width="250" height="286"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="description">Клеопатра, 3 месяца</div> | ||
<div class="close-photo"></div> | ||
</div> | ||
<div class="photo britanskaya"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
тут прекрасно подойдет <figure>
<div class="photo abissinskaya"> | ||
<img src="img/Абиссинская1.jpg" alt="Абиссинская кот Гоша" width="250" height="286"> | ||
<div class="description">Гоша, 2 года</div> | ||
<div class="close-photo"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем этот элемент?
<div class="sort-rates"> | ||
<input type="checkbox" id="sort-rating-flex" class="sort-rating-checkbox"> | ||
<label for="sort-rating-flex" class="sort-rating-checkbox">по убыванию</label> | ||
<div class="rates"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем эта обертка?
</main> | ||
<footer> | ||
<span>©ООО Бабуленькины котятки</span> | ||
<a href="#">Наш адрес: ул.Котовая, 5</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем эта ссылка?
<div class="rates"> | ||
<div class="rate-item nine"> | ||
<div>Абиссинская</div> | ||
<div class="rate"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Лишний элемент. Как сделать по-другому?
<label for="sort-rating-flex" class="sort-rating-checkbox">по убыванию</label> | ||
<div class="rates"> | ||
<div class="rate-item nine"> | ||
<div>Абиссинская</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужен ли этот <div>
?
Посмотреть решение