-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Кобяков Сергей #37
base: master
Are you sure you want to change the base?
Кобяков Сергей #37
Conversation
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кажется, ты забыл все предыдущие замечания к задачам :с
</head> | ||
<body> | ||
<div class="wrapper"> | ||
<div class="content"> | ||
<div class="title">Бабуленькины котятки</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
header
? h1
?
<input id="select-british" type="checkbox" class="select-british"> | ||
<input id="select-blue" type="checkbox" class="select-blue"> | ||
<input id="select-siamese" type="checkbox" class="select-siamese"> | ||
<div class="cat-breed"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nav
<span class="select-breed"><span class="breed-name">Сиамская</span></span> | ||
</label> | ||
</div> | ||
<div class="cat-gallery"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<div class="cat-gallery">
<div class="line">
<div class="photo"></div>
<div class="photo"></div>
</div>
<div class="line">
<div class="photo"></div>
<div class="photo"></div>
<div class="photo"></div>
</div>
<div class="line">
<div class="photo"></div>
<div class="photo"></div>
</div>
<div class="line">
<div class="photo"></div>
</div>
</div>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
и да main
<div class="line"><div class="photo"></div><div class="photo"></div></div> | ||
<div class="line"><div class="photo"></div></div> | ||
</div> | ||
<div class="cat-rating-box"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside
</div> | ||
</div> | ||
</div> | ||
<div class="footer"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
footer
flex-direction: column; | ||
} | ||
|
||
.breed-rating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
у этого класса точно такие же свойства, как у .cat-rating-info
|
||
label | ||
{ | ||
font-family: Tahoma, sans-serif; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
вместо того, чтобы везде писать это семейство, просто задавай его у body, например
.rating | ||
{ | ||
display: flex; | ||
flex-direction: row; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
по умолчанию
background: linear-gradient(to right, #fff601, #fff); | ||
border-left: 1px solid #b2ac01; | ||
border-right: 1px solid #cacccb; | ||
width: 131px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
то есть рейтинг 8 и рейтинг 6 будут одинаковой длины?
width: 200px; | ||
height: 70px; | ||
margin-top: 195px; | ||
background-color: rgba(0,0,0,.37); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
пробелы
|
🍅 Не пройден линтинг или базовые тесты |
🍅 Не пройден линтинг или базовые тесты |
🍏 Пройден линтинг и базовые тесты |
🍏 |
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍅
</nav> | ||
<main> | ||
<div class="line"> | ||
<div class="image"><img src="images/1.jpg" alt="Cat Photo"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Как-то описания без фантазии :(
|
||
.line:nth-child(4n-3) .image:nth-child(1):hover::after | ||
{ | ||
content: 'Гоша, 4 года'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ну нет, так никто никогда не делает – контент должен быть в HTML, а не в CSS
cursor: pointer; | ||
} | ||
|
||
.select-abyssinian:checked ~ main .line:nth-child(1) .image:nth-child(1) img, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Всё это можно было сделать гораздо проще, если бы у каждой картинки был бы нужный класс, а сейчас я могу добавить/удалить новую картинку и мне придется переделывать CSS чуть более чем полностью
Посмотреть решение