Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude ~/.m2 #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Exclude ~/.m2 #15

wants to merge 2 commits into from

Conversation

domkm
Copy link

@domkm domkm commented Sep 23, 2016

We ran into Heroku slug size issues but the current exclude-m2 branch is broken and, since it is conditional exclusion, it might make sense for the feature to be in master.

Based on fdc6c89 and #7

@paxan
Copy link
Contributor

paxan commented Dec 15, 2016

Does this mean that when /app/.m2 is missing in the slug, your boot-clj Heroku app will commence to download Maven artifacts at every deploy, restart, and so on?

If I remember right, Heroku has a limit on how long the app can take before it binds to PORT. I've ran into issues before when the app takes too long to boot because it was bootstrapping itself for too long.

@paxan
Copy link
Contributor

paxan commented Dec 15, 2016

@domkm, I've just realized that it depends on what you do at build time! E.g. if you build an uberjar, then /app/.m2 is entirely useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants