Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Oracle dialect #995

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Support Oracle dialect #995

merged 2 commits into from
Oct 26, 2024

Conversation

mattn
Copy link
Contributor

@mattn mattn commented Jun 2, 2024

Hi, I'm author of go-oci8. Now I added support for Oracle dialect. Currently, this todo app is working on my environment with small changes for driver name.

https://github.com/mattn/todo-webapp

@mattn mattn force-pushed the support-oracle branch from 18c9a3d to 3c29522 Compare June 2, 2024 11:39
@vmihailenco vmihailenco merged commit a6f81ee into uptrace:master Oct 26, 2024
3 of 4 checks passed
@vmihailenco
Copy link
Member

@mattn nice, thanks! Any chance we can start running tests for Oracle here?

Also, if you can provide any examples, I will add the to the docs next to the other dialects.

@mattn
Copy link
Contributor Author

mattn commented Oct 26, 2024

Thanks. This is an exmaple app using uptrace/bun and go-oci8.

https://github.com/mattn/todo-webapp/blob/oci8/main.go

What example do you prefer?

@vmihailenco
Copy link
Member

@mattn added an example to the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants