Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: has-many join failing with pointer key fields (#950) #983

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

jeffreydwalter
Copy link
Contributor

No description provided.

@jeffreydwalter jeffreydwalter changed the title #950: Fix issue with has-many join and pointer fields (bug): #950: Fix issue with has-many join and pointer fields Apr 27, 2024
@jeffreydwalter jeffreydwalter force-pushed the master branch 2 times, most recently from 4fa93e1 to 0b09797 Compare April 27, 2024 22:05
@jeffreydwalter jeffreydwalter changed the title (bug): #950: Fix issue with has-many join and pointer fields bug: Fix issue with has-many join and pointer fields (#950) Apr 27, 2024
@jeffreydwalter jeffreydwalter changed the title bug: Fix issue with has-many join and pointer fields (#950) fix: fix issue with has-many join and pointer fields (#950) Apr 27, 2024
@jeffreydwalter
Copy link
Contributor Author

@vmihailenco can I please get this PR merged asap? I'm trying to migrate an existing codebase to bun and this is a blocker. Thanks.

@jeffreydwalter jeffreydwalter force-pushed the master branch 3 times, most recently from 5aa6403 to e8cc338 Compare April 29, 2024 16:44
@jeffreydwalter jeffreydwalter changed the title fix: fix issue with has-many join and pointer fields (#950) fix: has-many join failing with pointer key fields (#950) Apr 29, 2024
@jeffreydwalter
Copy link
Contributor Author

@vmihailenco you still alive out there? :) Would really appreciate a PR merge here.

@Riphal
Copy link

Riphal commented Jun 3, 2024

Any updates, will this be merged soon?

cc @vmihailenco

@jeffreydwalter
Copy link
Contributor Author

jeffreydwalter commented Jul 9, 2024

@emoss08 any chance you could merge this PR? It's been THREE months...

@emoss08
Copy link
Contributor

emoss08 commented Jul 17, 2024

@emoss08 any chance you could merge this PR? It's been THREE months...

I don't have write access sorry :(

@jeffreydwalter
Copy link
Contributor Author

@vmihailenco are you still maintaining this project? Do you need help? This PR is over 3 months old and your library is unusable without the change.

@jeffreydwalter
Copy link
Contributor Author

@vmihailenco what do I need to do to get you to look at this? It's a critical bug for me and it's been months.

@jeffreydwalter
Copy link
Contributor Author

@vmihailenco can you at least have the courtesy to tell me why you've been ignoring this PR? Is there a problem with it?

@thecampagnards
Copy link
Contributor

any news ?

@vmihailenco vmihailenco merged commit cbc5177 into uptrace:master Oct 26, 2024
4 checks passed
@vmihailenco
Copy link
Member

@jeffreydwalter I just don't enough time & energy to check all the emails from this repo any more. I am still occasionally active here, but this PR somehow slipped my attention. Sorry for this.

It would be nice if we can add another maintainer, but not sure if we have any volunteers that have submitted enough PRs so far... May be @j2gg0s ?

And thanks for fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants