CreateTableQuery: Small cleanups for foreign key handling #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevzzz
changed the title
vmihailenco
reviewed
Jan 6, 2024
bevzzz
added a commit
to bevzzz/bun
that referenced
this pull request
Jan 7, 2024
HasOneRelation and BelongsToRelation aren't checked anywhere at the moment, but the change is necessary to avoid any hidden bugs in the future.
+ Document the logic for omitting the clause for some Relations The name References() is derived from the REFERENCES keyword used to declare an FK constraint
Subsequent calls to WithForeignKeys() should not create additional FOREIGN KEY clauses in the query. DBs probably have no problem dealing with duplicated FKs, but this behaviour is hardly expected / relied on by anyone.
bevzzz
force-pushed
the
chore/relations_cleanup
branch
from
90e75bf to
c0aa6a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just some cosmetic changes I've stumbled upon while working on another ticket:
HasOneRelationandBelongsToRelationplaces, so that the type is set correctly. That did not affect the functionality, but could prevent some obscure bugs in the future.References() boolmethod toRelationto highlight the difference between the ones that need aFOREIGN KEYclause themselves and the ones that are referenced by other tables instead..WithForeignKeys()