feat: add an ordered map to remove unnecessary dependencies #1074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiscs
force-pushed
the
packed-ordered-map
branch
3 times, most recently
from
053a37c to
23a65ea
Compare
Tiscs
force-pushed
the
packed-ordered-map
branch
from
f9290b3 to
9fea143
Compare
|
Do you mind handling the updates on master? |
Rebased to uptrace/bun:master now. |
|
@vmihailenco Should we consider compatibility with at least two minor go versions? |
Yes, let's do it. The old map implementation was actually compatible with Go 1.22, but I've used new Go iterators which are 1.23+ only. But the new map is also fine. |
vmihailenco
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a past commit (a08c009), a non-tagged version of go-ordered-map v2 was introduced, but only for the ordered traversal of the table and column information, and some unnecessary indirect dependencies were introduced.
This PR provides an in-package ordered map implementation so that go-ordered-map v2 and its related dependencies can be removed, and returned to go 1.22, which is still widely used.