Use module attribute

upmaru · Nov 1, 2024 · 68ac3a0 · 68ac3a0
1 parent 64c91e1
commit 68ac3a0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/lib/uplink/packages/instance/bootstrap.ex b/lib/uplink/packages/instance/bootstrap.ex
@@ -19,6 +19,13 @@ defmodule Uplink.Packages.Instance.Bootstrap do
   alias Uplink.Clients.LXD
   alias Uplink.Clients.LXD.Cluster.Member
 
+  @instance_bootstrappable_states [
+    "executing",
+    "completed",
+    "refreshing",
+    "degraded"
+  ]
+
   @transition_parameters %{
     "from" => "uplink",
     "trigger" => false
@@ -77,12 +84,7 @@ defmodule Uplink.Packages.Instance.Bootstrap do
          } = state,
          %{"slug" => instance_name}
        )
-       when install_current_state in [
-              "executing",
-              "completed",
-              "refreshing",
-              "degraded"
-            ] do
+       when install_current_state in @instance_bootstrappable_states do
     placement_name = Placement.name(instance_name)
 
     Instances.mark("executing", install.id, instance_name)

diff --git a/test/uplink/metrics/pipeline_test.exs b/test/uplink/metrics/pipeline_test.exs
@@ -93,7 +93,7 @@ defmodule Uplink.Metrics.PipelineTest do
   } do
     ref = Broadway.test_message(Uplink.Metrics.Pipeline, message)
 
-    assert_receive {:ack, ^ref, [%{data: data}], []}
+    assert_receive {:ack, ^ref, [%{data: data}], []}, 10_000
 
     assert %{load: load} = data