explicitly check for error state in bento results from summon #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise this errors out when expecting a number in total_items See: #80
|
Note: this would still be "fixed" without the Gemfile.lock upgrade of bento_search. The only thing the upgrade gets us is a slightly more informative error message. 84fa596 initially just echoes this back to user. In addition (or perhaps instead) we probably want to log this to notify us of these errors so that we can follow up on them ... @mksndz thoughts? |
|
If we're going to continue to work on a fork of To use a Honeybadger notification, you can call |
magibney
added a commit
that referenced
this pull request
Sep 30, 2020
magibney
added a commit
that referenced
this pull request
Sep 30, 2020
…n_qparser_errors follow-up to PR #92; mitigate server-side summon API qparser errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise this errors out when expecting a number in total_items
See: #80