chore: move poster methods to its file

up1512001 · Nov 15, 2024 · a631118 · a631118
1 parent 7c97a35
commit a631118
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 17 deletions.
diff --git a/packages/block-library/src/video/edit.js b/packages/block-library/src/video/edit.js
@@ -54,7 +54,6 @@ function VideoEdit( {
 } ) {
 	const instanceId = useInstanceId( VideoEdit );
 	const videoPlayer = useRef();
-	const posterImageButton = useRef();
 	const { id, controls, poster, src, tracks } = attributes;
 	const [ temporaryURL, setTemporaryURL ] = useState( attributes.blob );
 	const dropdownMenuProps = useToolsPanelDropdownMenuProps();
@@ -174,13 +173,6 @@ function VideoEdit( {
 		);
 	}
 
-	function onRemovePoster() {
-		setAttributes( { poster: undefined } );
-
-		// Move focus back to the Media Upload button.
-		posterImageButton.current.focus();
-	}
-
 	return (
 		<>
 			{ isSingleSelected && (
@@ -230,8 +222,6 @@ function VideoEdit( {
 					<PosterImage
 						poster={ poster }
 						setAttributes={ setAttributes }
-						posterImageButton={ posterImageButton }
-						onRemovePoster={ onRemovePoster }
 						instanceId={ instanceId }
 					/>
 				</ToolsPanel>

diff --git a/packages/block-library/src/video/poster-image.js b/packages/block-library/src/video/poster-image.js
@@ -8,14 +8,10 @@ import {
 	__experimentalToolsPanelItem as ToolsPanelItem,
 } from '@wordpress/components';
 import { __, sprintf } from '@wordpress/i18n';
+import { useRef } from '@wordpress/element';
 
-function PosterImage( {
-	poster,
-	setAttributes,
-	posterImageButton,
-	onRemovePoster,
-	instanceId,
-} ) {
+function PosterImage( { poster, setAttributes, instanceId } ) {
+	const posterImageButton = useRef();
 	const VIDEO_POSTER_ALLOWED_MEDIA_TYPES = [ 'image' ];
 
 	const videoPosterDescription = `video-block__poster-image-description-${ instanceId }`;
@@ -24,6 +20,13 @@ function PosterImage( {
 		setAttributes( { poster: image.url } );
 	}
 
+	function onRemovePoster() {
+		setAttributes( { poster: undefined } );
+
+		// Move focus back to the Media Upload button.
+		posterImageButton.current.focus();
+	}
+
 	return (
 		<ToolsPanelItem
 			label={ __( 'Poster image' ) }