Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create configtips.yml #4218

Closed
wants to merge 4 commits into from
Closed

Conversation

alexvsav
Copy link

I hope our project qualifies for up for grabs!
Happy Hacktoberfest 🦾

@shiftbot
Copy link
Contributor

shiftbot commented Sep 28, 2023

👋 I'm a robot checking the state of this pull request to save the human reviewers time. I noticed this PR added or modififed the data files under _data/projects/ so I had a look at what's changed.

As you make changes to this pull request, I'll re-run these checks.

_data/projects/configtips.yml

A label named hacktoberfest has been found on GitHub and it currently has 1 issue - this should be ready to merge!

Copy link
Author

@alexvsav alexvsav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to fit guidelines

Copy link
Member

@shiftkey shiftkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In it's current form this isn't an ideal fit for Up for Grabs

- packagejson
upforgrabs:
name: hacktoberfest
link: https://github.com/CircleCI-Public/Config.Tips/issues/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 this should link to a list of issues in the repository that are ideal for contributors. The only issue with this label is CircleCI-Archived/Config.Tips#63 which looks like a greeting.

@shiftkey
Copy link
Member

Closing this out as I think CircleCI-Archived/Config.Tips#63 is very broad, and not aligned with how this project is setup

@shiftkey shiftkey closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants