Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brennan Carson rename manpages #10

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

brennan-carson
Copy link

Added ompi- prefix to instances of prte in the context of a command within the prrte manpages, as well as renamed them to accommodate this prefix

Copy link

github-actions bot commented Dec 3, 2024

Hello! The Git Commit Checker CI bot found a few problems with this PR:

970af5a: Finalized changes to prrte manpages with -ompi pre...

  • check_signed_off: does not contain a valid Signed-off-by line

c0610b2: Updated and corrected ompi- prefix for prrte manpa...

  • check_signed_off: does not contain a valid Signed-off-by line

0ae0b93: Added ompi- prefix for all instances of prte comma...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@jsquyres
Copy link

jsquyres commented Dec 4, 2024

@brennan-carson I think there are 2 things left to do on this PR:

  1. Add the signed-off-by lines in your commit messages (you'll need to do an interactive rebase and r / reword each commit message to add the signed-off-by lines).
  2. Fix the sphinx warning (which acts as an error in CI builds).

@brennan-carson brennan-carson force-pushed the brennancarson-rename-manpages branch from 970af5a to 65f9968 Compare December 5, 2024 00:40
Added ompi- prefix for all instances of prte commands within both the man/man1 and man/man5 directories, and also renamed necessary files to accommodate changes.

Updated and corrected ompi- prefix for prrte manpages

Finalized changes to prrte manpages with -ompi prefix

Signed-off-by: Brennan Carson <[email protected]>
@brennan-carson brennan-carson force-pushed the brennancarson-rename-manpages branch from b2bc79e to b9bbde7 Compare December 5, 2024 02:21
…s an error

Also fixed docs/Makefile.am for appropriate file renames

Signed-off-by: Brennan Carson <[email protected]>
@brennan-carson brennan-carson force-pushed the brennancarson-rename-manpages branch from b9bbde7 to ae40733 Compare December 5, 2024 02:32
Copy link

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo!

@brennan-carson brennan-carson merged commit 95c240e into capstone-devel Dec 5, 2024
11 checks passed
@brennan-carson brennan-carson deleted the brennancarson-rename-manpages branch December 5, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants