Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1434] fixed RegistrarCustody sandbox #375

Merged

Conversation

nickshatilo
Copy link
Member

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody, or RegistrarCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody, or RegistrarCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier is defined in contracts.
  • Make sure that the header is added to the new contract files, including RegistrarCustody.

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@nickshatilo nickshatilo requested a review from a team November 4, 2024 12:05
@nickshatilo nickshatilo self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 14.048 0
MintingManager 18.92 0
ProxyReader 15.176 0
RegistrarCustody 9.6 0
UNSRegistry 20.725 0

@nickshatilo nickshatilo merged commit e267906 into main Nov 4, 2024
8 checks passed
@nickshatilo nickshatilo deleted the nickshatilo/REG-1434/fix-registrar-custody-sandbox branch November 4, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants