Switch to new cluster and build credentials #20
Conversation
| @@ -25,6 +25,12 @@ jobs: | |||
| # Docker is preinstalled. | |||
| run: nix build .#dockerImage && ./result | docker load | |||
|
|
|||
| - name: Assume AWS role | |||
| uses: aws-actions/configure-aws-credentials@v4 | |||
There was a problem hiding this comment.
Just commenting early to say that I've been trying to avoid unnecessary use of actions as they're proprietary to GitHub, making the code less portable to other CI systems. They often do little more than a line or two of shell.
There was a problem hiding this comment.
Thanks for the feedback. Even though I do not agree I will take it in consideration.
|
@samhh @elcuervo can we go ahead and merge this? I kicked off a deployment today (to test out auto rotated access keys) and the build failed because the Looking at the mercury terraform - a seemingly valid build role is managed there but no IAM users. So, I think the best path forward is to just merge this PR as we want to move from IAM users to roles anyway. |
@samhh @elcuervo can we go ahead and merge this? It would be great to remove the underlying IAM user |
|
Nothing blocking this from my perspective. 🙂 |
No description provided.