fix(combobox/item): fix some items not add into allItems map #1368
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zernonia, just saw the new releases 😀 which reminds me of this PR, could you review this when you have time? Thanks. |
ineshbose
reviewed
Nov 21, 2024
2 tasks
zernonia
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1234
This pr fixes when
rootContext.isVirtual.value || rootContext.ignoreFilter.value || !rootContext.filterState.searchis false, the item will never add intoallItemsmap.To reproduce this bug, create a async combobox (e.g. the one in the story), before opening the dropdown, give any value to search query.
Added an event listener to apply filter when
allItemssize changes.* It uses
watchrather thanwatchDebouncedeven the items are set one by one because it's handled by vuewatch