Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gallery][Wasm] MediaPlayerElement, [X] Close button does not work for customizable option once click on the last sample option. #784

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

rafael-rosa-knowcode
Copy link
Contributor

@rafael-rosa-knowcode rafael-rosa-knowcode commented Jun 23, 2023

GitHub Issue (If applicable): #

Closes unoplatform/uno#12653

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When click close button, mediaplayer window for Customizable option should get close.

What is the new behavior?

When click close button, after try to enter on the MPE sample playlist, and enter in other sample mediaplayer window, as Customizable option, the window should get close.

Feature items/playlist is just implemented for ANDROID || IOS || MACOS
So in the Sample 5 (Playlist) we just show the first video.
And as requested we disable the feature on unsupported platform, so the Sample 5, playlist, do not show on other platforms.

image

And i added the references to test the MediaPlayer Skia on windows

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

github-actions bot commented Jun 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-moss-0b45eee0f-784.eastus2.1.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-moss-0b45eee0f-784.eastus2.1.azurestaticapps.net

@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue12653CloseDuePlaylist branch 2 times, most recently from ca03269 to afa456a Compare June 27, 2023 21:02
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-moss-0b45eee0f-784.eastus2.1.azurestaticapps.net

2 similar comments
@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-moss-0b45eee0f-784.eastus2.1.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://yellow-moss-0b45eee0f-784.eastus2.1.azurestaticapps.net

@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue12653CloseDuePlaylist branch from 9dd9bf3 to bb74b63 Compare July 24, 2023 10:58
@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-784.eastus2.3.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Jul 24, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-784.eastus2.3.azurestaticapps.net

@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue12653CloseDuePlaylist branch from d2b11e7 to 0742e1c Compare August 8, 2023 20:30
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-784.eastus2.3.azurestaticapps.net

1 similar comment
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-784.eastus2.3.azurestaticapps.net

@rafael-rosa-knowcode rafael-rosa-knowcode force-pushed the dev/ramr/issue12653CloseDuePlaylist branch from 54ac4a4 to d9b7b49 Compare August 9, 2023 00:07
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-784.eastus2.3.azurestaticapps.net

@MartinZikmund MartinZikmund merged commit 1ff3a8c into master Aug 9, 2023
@MartinZikmund MartinZikmund deleted the dev/ramr/issue12653CloseDuePlaylist branch August 9, 2023 10:11
@agneszitte
Copy link
Contributor

agneszitte commented Aug 14, 2023

https://github.com/Mergifyio backport legacy/4x

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link

mergify bot commented Aug 14, 2023

backport legacy/4x

✅ Backports have been created

MartinZikmund added a commit that referenced this pull request Aug 15, 2023
[Gallery][Wasm] MediaPlayerElement, [X] Close button does not work for customizable option once click on the last sample option. (backport #784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants