Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(unlock-app): Wallet-only auth for embedded paywall #15379

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Jan 16, 2025

Description

This PR introduces changes to the auth flow by updating login methods to exclusively support wallet-based authentication when authenticating via an embedded paywall.

ScreenGrab

Screenshot 2025-01-16 at 17 10 58

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 January 16, 2025 16:08
@cla-bot cla-bot bot added the cla-signed label Jan 16, 2025
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
unlock-static-site ⬜️ Ignored (Inspect) Jan 16, 2025 4:24pm
unlock-storybook ⬜️ Ignored (Inspect) Jan 16, 2025 4:24pm

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@0xTxbi 0xTxbi merged commit 5c965e6 into master Jan 16, 2025
14 checks passed
@0xTxbi 0xTxbi deleted the restrict-paywall-auth-methods branch January 16, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants