Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages/ui): Use shared CSS for docs and improve UI library structure #15141

Merged
merged 26 commits into from
Dec 3, 2024

Conversation

0xTxbi
Copy link
Member

@0xTxbi 0xTxbi commented Nov 28, 2024

Description

This PR updates our docs to use shared CSS from our UI package for consistent styling. It also improves the UI library structure to support this change.

ScreenGrab

Screenshot 2024-11-28 at 14 24 46

Issues

Fixes #15083
Refs #15083

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@0xTxbi 0xTxbi requested a review from julien51 November 28, 2024 13:26
@cla-bot cla-bot bot added the cla-signed label Nov 28, 2024
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Are you sure this looks great "in general? I see it on the page to burn tokens, but what about the other pages?

@0xTxbi
Copy link
Member Author

0xTxbi commented Dec 2, 2024

Very cool! Are you sure this looks great "in general? I see it on the page to burn tokens, but what about the other pages?

absolutely!

@0xTxbi 0xTxbi merged commit 2ad2a2f into master Dec 3, 2024
13 checks passed
@0xTxbi 0xTxbi deleted the docs-styling branch December 3, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-use CSS libraries in docs
2 participants