Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add RESTful API to API documentation #2680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chronark
Copy link
Collaborator

@chronark chronark commented Nov 25, 2024

This PR adds the RESTful API.mdx file to the API documentation.

Summary by CodeRabbit

  • New Features
    • Introduced a comprehensive guide on RESTful API design and best practices.
    • Added sections on key terms, historical context, usage, best practices, and FAQs to enhance understanding.
    • Included recommended readings for further exploration of RESTful API principles.

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:10pm
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:10pm
play ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:10pm
workflows ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:10pm
www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:10pm

Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: 4c95319

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Nov 25, 2024

📝 Walkthrough

Walkthrough

A new file named restful-api.mdx has been created, providing a detailed guide on RESTful API design and best practices. The document includes sections on key terms, historical context, usage, best practices, recommended readings, and FAQs. It emphasizes the principles of REST compliance, CRUD operations, and stateless design, aiming to assist developers in understanding and implementing effective RESTful APIs.

Changes

File Path Change Summary
apps/www/content/glossary/restful-api.mdx New file created with a comprehensive guide on RESTful API design, including key sections such as takeaways, historical context, usage, best practices, and FAQs.

Possibly related PRs

  • feat(glossary): Adds statelessness.mdx to glossary #2649: The addition of the statelessness.mdx file is related to the main PR as both documents focus on key concepts in API design, specifically the stateless nature of RESTful APIs, which is a significant topic in the restful-api.mdx guide.

Suggested labels

Documentation

Suggested reviewers

  • mcstepp
  • perkinsjr
  • MichaelUnkey

Warning

Rate limit exceeded

@chronark has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 46b0691 and 4c95319.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🧹 Outside diff range and nitpick comments (3)
apps/www/content/glossary/restful-api.mdx (3)

6-6: Consider populating the categories array.

The categories array is currently empty. Consider adding relevant categories like "API", "Web Services", or "Integration" to improve content discoverability.


58-62: Consider adding HATEOAS principle.

The introduction provides a good overview of RESTful APIs, but it could be enhanced by mentioning HATEOAS (Hypermedia as the Engine of Application State) as it's a key principle of REST architecture.

Consider adding a sentence like:

 RESTful APIs are inherently **stateless**, meaning each request from a client to a server must contain all the information needed to understand and complete the request. The server does not store any state about the client session, which enhances scalability by reducing server memory requirements. Communication between client and server occurs using standard HTTP protocols, with data typically returned in **JSON** or **XML** format.
+Additionally, true RESTful APIs implement HATEOAS (Hypermedia as the Engine of Application State), where responses include links to related resources, enabling clients to dynamically discover available actions.

117-121: Add query parameter examples for filtering and pagination.

Since filtering and pagination were mentioned in the best practices, it would be helpful to include examples of these in the blog platform API design.

Consider adding these examples:

 - **List all posts**: `GET /posts`
+- **Filter posts**: `GET /posts?author=johndoe&category=tech`
+- **Paginated posts**: `GET /posts?page=1&limit=10`
 - **Create a new post**: `POST /posts`
 - **Read a specific post**: `GET /posts/{id}`
 - **Update a post**: `PUT /posts/{id}`
 - **Delete a post**: `DELETE /posts/{id}`
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 46b0691 and 4c95319.

📒 Files selected for processing (1)
  • apps/www/content/glossary/restful-api.mdx (1 hunks)

Comment on lines +40 to +41
- url: http://www.ics.uci.edu/~fielding/pubs/dissertation/rest_arch_style.htm
title: RESTful Web Services
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incorrect URL for "RESTful Web Services" reference.

The URL points to Fielding's dissertation but the title suggests it should link to a different resource about RESTful Web Services.

Consider updating to a more appropriate URL that matches the title, or update the title to match the current URL's content: "Architectural Styles and the Design of Network-based Software Architectures".

question: What are the three principles for a RESTful API?
- answer: "A RESTful API consists of three major components: 1) Client: This is the application or software code that sends requests to the server for a resource. 2) Server: This is the application or software code that controls the resource. It processes the client's requests and sends responses. 3) Resource: This is the data or service that the client requests. It can be any information that can be named, such as a document or an image. The client interacts with a representation of the resource, rather than the resource itself."
question: What are the three components of a RESTful API?
updatedAt: 2024-11-25T19:00:24.000Z
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Future date detected in updatedAt field.

The updatedAt timestamp is set to November 25, 2024, which is in the future.

Update the timestamp to reflect the current date or remove it to let the system manage this automatically.

Comment on lines +95 to +103
```json
GET /users/123
Response:
{
"id": "123",
"name": "John Doe",
"email": "[email protected]"
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance API example with headers and status code.

The API example would be more complete with HTTP headers and status code information.

Consider updating the example to include these details:

 GET /users/123
+
+HTTP/1.1 200 OK
+Content-Type: application/json
+
 Response:
 {
   "id": "123",
   "name": "John Doe",
   "email": "[email protected]"
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
```json
GET /users/123
Response:
{
"id": "123",
"name": "John Doe",
"email": "[email protected]"
}
```
```json
GET /users/123
HTTP/1.1 200 OK
Content-Type: application/json
Response:
{
"id": "123",
"name": "John Doe",
"email": "[email protected]"
}
```

Copy link
Contributor

github-actions bot commented Nov 25, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant