Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AdonisJS + Unkey Ratelimit route #2493

Closed
wants to merge 1 commit into from

Conversation

Ionfinisher
Copy link
Contributor

@Ionfinisher Ionfinisher commented Oct 18, 2024

Ratelimiting AdonisJS routes with Unkey

Github repo: https://github.com/Ionfinisher/unkey-adonisjs-ratelimit

Fixes #2150

Summary by CodeRabbit

  • New Features
    • Introduced a new template for integrating Unkey with the AdonisJS framework, enhancing available resources for API protection.
    • Added a repository link for the AdonisJS + Unkey Ratelimit starter template.

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 81e9912

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 18, 2024

@Ionfinisher is attempting to deploy a commit to the Unkey Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Oct 18, 2024

📝 Walkthrough

Walkthrough

The pull request introduces a new entry to the documentation for templates that demonstrate the integration of Unkey with the AdonisJS framework. This entry includes details such as the date, author, title, and a link to the corresponding repository. The update aims to enhance the collection of templates available for developers looking to implement API protection using Unkey.

Changes

Files Change Summary
oss.gg/7_create_a_template.md Added a new entry for "AdonisJS + Unkey Ratelimit starter" with details and repository link.

Assessment against linked issues

Objective Addressed Explanation
Add a new entry for contributions (2150)

Possibly related PRs

Suggested labels

🕹️ oss.gg, :joystick: 750 points, hacktoberfest

Suggested reviewers

  • mcstepp
  • chronark
  • perkinsjr
  • MichaelUnkey

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
engineering ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:54pm

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d774a4c and 81e9912.

📒 Files selected for processing (1)
  • oss.gg/7_create_a_template.md (1 hunks)
🧰 Additional context used

Comment on lines +57 to +58
» 18-October-2024 Teddy ASSIH [AdonisJS + Unkey Ratelimit starter](https://github.com/Ionfinisher/unkey-adonisjs-ratelimit)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Missing MIT License in the repository.

The repository Ionfinisher/unkey-adonisjs-ratelimit does not contain an MIT License. Please add an MIT License to comply with the requirements.

🔗 Analysis chain

LGTM! New entry follows the correct format.

The new entry for the AdonisJS + Unkey Ratelimit starter template is correctly formatted and consistent with previous entries. It appears to meet the basic requirements stated in the file.

To ensure full compliance with the requirements, please verify:

  1. The repository is MIT licensed.
  2. The repository contains a README.md file with a quickstart guide.

You can use the following script to check these requirements:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify MIT license and README.md existence in the new template repository

# Clone the repository
git clone https://github.com/Ionfinisher/unkey-adonisjs-ratelimit.git temp_repo
cd temp_repo

# Check for MIT license
if grep -q "MIT License" LICENSE; then
  echo "MIT License found"
else
  echo "MIT License not found"
fi

# Check for README.md and look for quickstart guide
if [ -f README.md ]; then
  echo "README.md found"
  if grep -iq "quickstart" README.md; then
    echo "Quickstart guide found in README.md"
  else
    echo "Quickstart guide not found in README.md"
  fi
else
  echo "README.md not found"
fi

# Clean up
cd ..
rm -rf temp_repo

Length of output: 516

@chronark
Copy link
Collaborator

/award 750

@chronark chronark closed this Oct 29, 2024
Copy link

oss-gg bot commented Oct 29, 2024

Awarding Ionfinisher: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/Ionfinisher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] SIDE QUESTS: https://go.unkey.com/ossgg-challenges
2 participants