-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Unkey + Feathers template [SIDE QUEST] #2376
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@unrenamed is attempting to deploy a commit to the Unkey Team on Vercel. A member of the Team first needs to authorize it. |
Warning Rate limit exceeded@chronark has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 17 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve adding a new entry for a project titled "Starter template for Unkey Route protection in Hono Webframework in Cloudflare workers" by Prabin Subedi, dated 11-October-2024, to a contributions list. Additionally, it removes a duplicate entry for the same project to maintain uniqueness. The overall structure and requirements for submissions remain unchanged. Changes
Assessment against linked issues
Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
oss.gg/7_create_a_template.md (1)
41-41
: Fix typo and remove extra spaces in the link textThere's a typo in the word "protection" and extra spaces in the link text. Please apply the following changes:
-» 11-October-2024 by Prabin Subedi [Starter template for Unkey Route protecttion in Hono Webframework in Cloudflare workers ](https://github.com/prabincankod/hono-unkey-cflare) +» 11-October-2024 by Prabin Subedi [Starter template for Unkey Route protection in Hono Webframework in Cloudflare workers](https://github.com/prabincankod/hono-unkey-cflare)This will correct the spelling and resolve the Markdownlint warning about spaces inside link text.
🧰 Tools
🪛 Markdownlint
41-41: null
Spaces inside link text(MD039, no-space-in-links)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- oss.gg/7_create_a_template.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint
oss.gg/7_create_a_template.md
41-41: null
Spaces inside link text(MD039, no-space-in-links)
🔇 Additional comments (1)
oss.gg/7_create_a_template.md (1)
41-42
: LGTM! New entries added successfullyThe new entries for Unkey templates have been added successfully:
- Hono Webframework in Cloudflare workers by Prabin Subedi
- Feathers API with Custom Key Auth Strategy by Nazar Poshtarenko
These additions align with the PR objectives of introducing new Unkey templates. Great job on contributing to the project!
As a reminder, please ensure that:
- The repositories are open source and MIT licensed.
- Each repository has a README.md with a quickstart guide.
- The templates are unique and not duplicates of existing ones on unkey.com/templates.
To verify the uniqueness and compliance of these new entries, you can run the following script:
This script will help ensure that the new entries meet all the requirements specified in the PR objectives.
✅ Verification successful
Verification Successful! All new Unkey template entries are unique, their repositories exist with proper README files, and both are MIT licensed.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the uniqueness of new entries and check their repositories # Test 1: Check for duplicates in the file echo "Checking for duplicates:" sort oss.gg/7_create_a_template.md | uniq -d # Test 2: Verify the existence of the repositories and their README files echo "Verifying repositories:" gh repo view prabincankod/hono-unkey-cflare gh repo view unrenamed/unkey-feathers echo "Checking for README.md files:" gh api repos/prabincankod/hono-unkey-cflare/contents/README.md gh api repos/unrenamed/unkey-feathers/contents/README.md # Test 3: Check if the repositories are MIT licensed echo "Checking for MIT license:" gh api repos/prabincankod/hono-unkey-cflare/license gh api repos/unrenamed/unkey-feathers/licenseLength of output: 17978
🧰 Tools
🪛 Markdownlint
41-41: null
Spaces inside link text(MD039, no-space-in-links)
Awarding unrenamed: 750 points 🕹️ Well done! Check out your new contribution on oss.gg/unrenamed |
What does this PR do?
Adds an Unkey template showcasing how to protect your Feathers backend with Custom Key Auth Strategy. https://github.com/unrenamed/unkey-feathers
Fixes #2150
Summary by CodeRabbit