Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update unbuild configuration to use pnpm workspace in examples… #462

Closed
wants to merge 4 commits into from

Conversation

Sunny-117
Copy link
Contributor

… directory<!--
PLEASE DO THIS BEFORE SUBMITTING A PR

  1. Make sure there is an issue covering the problem or idea first. If not, please create one. Reference it in the PR via "resolves #12312312"
  2. Please keep your changes minimal and split them if you need to.
  3. Ensure there is a minimal reproduction attached for bug fixes.

This will greatly help speed up the review process.

Thanks for your contribution ❤️
-->

@pi0
Copy link
Member

pi0 commented Dec 23, 2024

Appreciate the PR, however goal of examples is to be copy-pastable outside of monorepo and this change makes it more dependant.

We might however use a self-link on top level package.json to make them runnable standalone.

Closing this one. (also for other changes like drop unused import please feel free to make PR but please separated ones 🙏🏼 )

@pi0 pi0 closed this Dec 23, 2024
@Sunny-117
Copy link
Contributor Author

Appreciate the PR, however goal of examples is to be copy-pastable outside of monorepo and this change makes it more dependant.

We might however use a self-link on top level package.json to make them runnable standalone.

Closing this one. (also for other changes like drop unused import please feel free to make PR but please separated ones 🙏🏼 )

Thanks, I have submitted another PR as follows: #463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants