Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollup): de-default default export from stub #455

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix(rollup): de-default default export from stub #455

merged 3 commits into from
Dec 13, 2024

Conversation

danielroe
Copy link
Member

Testing latest unbuild with module-builder:

const _module = await jiti.import("/Users/daniel/code/nuxt/fonts/src/module.ts");

export default _module;

... and then

nuxtModule = await jiti.import(src, { default: true });

nuxtModule is '[object AsyncFunction]' and you access the module from nuxtModule.default

@danielroe danielroe requested a review from pi0 December 13, 2024 17:38
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might also fix more root causes in jiti but this seems valid for stub..

@pi0 pi0 changed the title fix: de-default default export from stub fix(rollup): de-default default export from stub Dec 13, 2024
@pi0 pi0 merged commit 7aacdff into main Dec 13, 2024
2 checks passed
@pi0 pi0 deleted the fix/stub branch December 13, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants