refactor: replace globby
w/ fast-glob
#418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the hood,
globby
is powered byfast-glob
with extra features, but none of them are utilized by theunbuild
.Since the
unbuild
doesn't utilize those extra features, I propose replacingglobby
withfast-glob
to reduce the installation size.Here is globby's feature description:
fast-glob
also has promise-based APIglobby
's multiple patterns support is powered byfast-glob
directly['foo*', '!foobar']
globby
's negated patterns support is also powered byfast-glob
directlyfoo → foo/**/*
unbuild
doesn't rely on this feature.gitignore
and similar ignore config filesunbuild
doesn't rely on this feature sinceglobby
disabled this feature by default andunbuild
doesn't enable it.cwd
unbuild
passed the string path tocwd
, and we can use Node.js built-inurl.fileURLToPath
in case we encounter URLs in the future.See also typescript-eslint/typescript-eslint#9453