fix: only externalize @types/ from devDependencies (#471)

unjs · Dec 27, 2024 · 9360293 · 9360293
1 parent 9dd09ee
commit 9360293
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/utils.ts b/src/utils.ts
@@ -167,7 +167,9 @@ export function inferPkgExternals(pkg: PackageJson): (string | RegExp)[] {
   const externals: (string | RegExp)[] = [
     ...Object.keys(pkg.dependencies || {}),
     ...Object.keys(pkg.peerDependencies || {}),
-    ...Object.keys(pkg.devDependencies || {}),
+    ...Object.keys(pkg.devDependencies || {}).filter((dep) =>
+      dep.startsWith("@types/"),
+    ),
     ...Object.keys(pkg.optionalDependencies || {}),
   ];
 

diff --git a/test/utils.test.ts b/test/utils.test.ts
@@ -61,7 +61,7 @@ describe("inferPkgExternals", () => {
         name: "test",
         dependencies: { react: "17.0.0" },
         peerDependencies: { "react-dom": "17.0.0" },
-        devDependencies: { "@types/react": "17.0.0" },
+        devDependencies: { "@types/react": "17.0.0", webpack: "*" },
         optionalDependencies: { test: "1.0.0", optional: "1.0.0" },
         exports: {
           ".": "index.js",