Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to get value using NumericLiteral or BooleanLiteral type keys #91

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: unable to get value using NumericLiteral or BooleanLiteral type keys #91

merged 1 commit into from
Nov 9, 2023

Conversation

PinkChampagne17
Copy link
Contributor

πŸ”— Linked issue

#90

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #90

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #91 (37726c6) into main (3c8250f) will increase coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   93.48%   93.53%   +0.05%     
==========================================
  Files          23       23              
  Lines        1749     1749              
  Branches      327      327              
==========================================
+ Hits         1635     1636       +1     
+ Misses        114      113       -1     
Files Coverage Ξ”
src/proxy/object.ts 95.45% <100.00%> (+0.75%) ⬆️

@antfu antfu merged commit 63d540d into unjs:main Nov 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to get value using NumericLiteral or BooleanLiteral type keys
2 participants