-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bundle recast #81
Conversation
It is a nice idea btw have you tried with impact on nuxi final size with double bundling of babel stuff? might worth to have a subpath with optional non bundled version. |
Babel is not bundled. Only |
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 92.40% 92.40%
=======================================
Files 23 23
Lines 1751 1751
Branches 322 322
=======================================
Hits 1618 1618
Misses 133 133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and introduce other improvements in next versions
Small notes:
Enabling |
since we are not bundling babel stuff yet, yes it is not much different. anyway consider that when bundling more, the startup (and sometimes runtime) time also improves with modification + memory usage is always less. |
Yeah, but I imagine we won't bundle Babel any sooner as it's quite big and commonly used, isn't it? I imagine we can bundle recast because it's a bit niche, and probably only used by |
Sure. That's what I wanted to share with you later about babel ;) |
Install size from 8.5MB -> 5.2MB (mainly Babel), from 35 packages to 4 packages. Get rid of many es5 polyfills and
ESM -> CJS -> ESM
glues. Result in around 5% faster, tho the performance isn't very related to our use cases.