Please add cmd_vel Geometry Twist example from ROS1 unitree_ros_to_real back! #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason you completely removed the cmd_vel subscribe example. This is the most useful thing in the SDK as far as ROS integration goes, please add this back, and finish fixing the example. I've got one minor thing broken here, but don't have the patience to fix it.
Oh yeah, I also fixed your broken Geometry / Twist keyboard example... did anyone even bother to test this stuff? I don't know ROS barely at all, and I can tell this was poorly done. What is the deal over there do you need help with ROS as a company in general?
unitreerobotics/unitree_ros_to_real#50