Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/tz aware dta #2054

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Feat/tz aware dta #2054

merged 7 commits into from
Nov 6, 2023

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Nov 4, 2023

fixes #2000.

Summary

  • adds support for time index time zone conversion with parameter tz before generating/computing holidays and datetime attributes.
    • darts.utils.timeseries_generation.datetime_attribute_timeseries
    • darts.utils.timeseries_generation.holidays_timeseries
    • all time axis encoders and add_encoders dict for automatic encoders in forecasting models
    • darts.Timeseries.add_holidays
      - darts.Timeseries.add_datetime_attribute

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
darts/dataprocessing/encoders/encoders.py 97.68% <100.00%> (+0.07%) ⬆️
darts/models/forecasting/arima.py 93.75% <ø> (ø)
darts/models/forecasting/auto_arima.py 96.77% <ø> (ø)
darts/models/forecasting/block_rnn_model.py 98.27% <ø> (-0.03%) ⬇️
darts/models/forecasting/catboost_model.py 98.41% <ø> (ø)
darts/models/forecasting/croston.py 90.69% <ø> (ø)
darts/models/forecasting/dlinear.py 99.12% <ø> (ø)
darts/models/forecasting/kalman_forecaster.py 97.36% <ø> (ø)
darts/models/forecasting/lgbm.py 100.00% <ø> (ø)
...arts/models/forecasting/linear_regression_model.py 94.44% <ø> (ø)
... and 18 more

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@dennisbader dennisbader requested a review from madtoinou November 4, 2023 19:55
Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few typo here and there.

darts/utils/timeseries_generation.py Outdated Show resolved Hide resolved
darts/utils/timeseries_generation.py Outdated Show resolved Hide resolved
darts/dataprocessing/encoders/encoders.py Outdated Show resolved Hide resolved
@dennisbader dennisbader merged commit 772d705 into master Nov 6, 2023
8 of 9 checks passed
@dennisbader dennisbader deleted the feat/tz_aware_dta branch November 6, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Allow different timezones in datetime_attribute_timeseries, other funcs and encoders
3 participants