Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/neural prophet #1436

Draft
wants to merge 25 commits into
base: master
Choose a base branch
from
Draft

Feat/neural prophet #1436

wants to merge 25 commits into from

Conversation

BlazejNowicki
Copy link
Contributor

Neural Prophet

Added basic wrapper for Neural Prophet.

Supported features

Univariate ✅
Multivariate ✅
Probabilistic ⬜️
Multiple-series training ⬜️
Past-observed covariates support ✅
Future-known covariates ✅

Other information

Usage examples in notebook:
neural_examples/examples.ipynb
This will be moved to another notebook or completely removed before merge.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Base: 93.94% // Head: 93.21% // Decreases project coverage by -0.73% ⚠️

Coverage data is based on head (14f215a) compared to base (9c23beb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1436      +/-   ##
==========================================
- Coverage   93.94%   93.21%   -0.74%     
==========================================
  Files         122      123       +1     
  Lines       10723    10792      +69     
==========================================
- Hits        10074    10060      -14     
- Misses        649      732      +83     
Impacted Files Coverage Δ
darts/models/forecasting/neural_prophet_model.py 0.00% <0.00%> (ø)
darts/ad/anomaly_model/filtering_am.py 91.93% <0.00%> (-0.13%) ⬇️
darts/timeseries.py 91.92% <0.00%> (-0.06%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 89.50% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 99.27% <0.00%> (-0.01%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -0,0 +1,230 @@
"""
Copy link
Contributor

@hrzn hrzn Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few generic comments about the PR:

  • So far I think that the pinned requirement on Pytorch Lightning will be a no-go for the moment for us unfortunately.
  • Could you import the model from darts/models/__init__.py ?
  • Could you stash your changes to the two notebooks?
  • Your model implementation is missing an abstract method implementation (_model_encoder_settings). But this can wait (don't spend more time on this until the dependency situation is figured out).

@ourownstory
Copy link

@BlazejNowicki Thank you for making NeuralProphet accessible to Darts! Let us know if you can use help with supporting more of the model's capabilities.

@hrzn Please excuse the delay in responding to the issue you raised. The dependencies were unnecessarily strict and have been relaxed. I hope this helps.
response to your issue
addressed in this PR

@hrzn
Copy link
Contributor

hrzn commented Feb 3, 2023

@BlazejNowicki Thank you for making NeuralProphet accessible to Darts! Let us know if you can use help with supporting more of the model's capabilities.

@hrzn Please excuse the delay in responding to the issue you raised. The dependencies were unnecessarily strict and have been relaxed. I hope this helps. response to your issue addressed in this PR

Thanks a lot @ourownstory !

@AndrewJGroves
Copy link

Hi, is this something still be looked into?

@ourownstory
Copy link

Happy to support anyone wanting to complete this!

@cargecla1
Copy link

cargecla1 commented May 14, 2024

Happy to support anyone wanting to complete this!

Hello @ourownstory ,

I would like to do it, it is something I thought it will be good to do but didn't notice that someone else started it before.

Any chance you can also assist to finish this PR: #2092? The team has been busy.

Cheers.

@Ashish-Surve
Copy link

Has this been added to darts or still work on progress, if required I can look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants