Remove Joining_Group numeric constants from UCD_Types #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
approved these changes
Nov 14, 2024
macchiati
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently discussed in #756 (comment).
UCD_Types is part of the most ancient layers of these tools:
unicodetools/unicodetools/src/main/java/org/unicode/text/UCD/UCD_Types.java
Lines 2 to 3 in 6da6862
It is only used in very limited contexts by the more recent strata which generate and parse the bulk of the UCD.
In particular, these constants are not used, and they are annoying to maintain (especially when merging independent proposals).