Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variation selectors to emoji alt attributes (#700) #920

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add variation selectors to emoji alt attributes (#700) #920

merged 1 commit into from
Sep 3, 2024

Conversation

nedley
Copy link
Contributor

@nedley nedley commented Aug 20, 2024 •
edited by markusicu
Loading

@nedley nedley linked an issue Aug 20, 2024 that may be closed by this pull request
Add variation selectors to the "alt=''" tags in the "Emoji Presentation Sequences" page (emoji-variants.html) #700
Closed
@nedley nedley changed the title Add variation selectors to emoji alt properties (#700) Add variation selectors to emoji alt attributes (#700) Aug 20, 2024
@nedley
Copy link
Contributor Author

nedley commented Aug 20, 2024

Retitled: alt attributes, not properties.

markusicu
markusicu approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look plausible. I just don't have enough context for this code to really understand the effects.

@nedley nedley merged commit e89069b into main Sep 3, 2024
20 checks passed
@nedley nedley deleted the ned/emoji_vses branch September 3, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@macchiati macchiati macchiati approved these changes

@kenlunde kenlunde kenlunde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add variation selectors to the "alt=''" tags in the "Emoji Presentation Sequences" page (emoji-variants.html)
4 participants
@nedley @kenlunde @macchiati @markusicu