Always use latest Unicode version when building emoji #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
reviewed
Aug 19, 2024
macchiati
previously approved these changes
Aug 19, 2024
meaning i suggest using squash-and-merge -- not squashing and then waiting for people again |
Understood—I was waiting for the build checks to complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building emoji 16.0 charts I remembered/discovered that the latest Unicode version was only used during beta. Remove the
IS_BETAchecks for everything but human-readable text and renameLATESTtoPROPS. I’m leaving most other variables alone in case we want to bring back the ability to build charts for the previous version.