UTS46 replace disallowed_STD3_ with check in Validity Criteria #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
requested review from
macchiati,
asmusf,
cjchapman,
PeterConstable,
josh-hadley and
Ken-Whistler
markusicu
force-pushed
the
uts46-std3-postprocess
branch
from
ec3ff84 to
3b6f824
Compare
|
Changes approved, action item recorded, tests pass now. Please review. |
|
I could live with a rubber stamp, too... |
josh-hadley
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[180-A61] Action Item for Markus Scherer, PAG: In UAX #46, handle UseSTD3ASCIIRules only in the Validity Criteria. In the IDNA Mapping Table, replace Status disallowed_STD3_valid with valid, and replace disallowed_STD3_mapped with mapped. Include a note in the Modifications section of edge cases of labels that are no longer unnecessarily disallowed. For Unicode 16.0. See L2/24-162 item 7.1.
See also
For the IdnaMappingTable.txt changes, ignore whitespace changes. The Status column became narrower.
First commit: Test case with fullwidth equals + combining solidus overlay which changes behavior.
Second commit: Do what the action item says, and adjust test expectations.