Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make emoji-ordering-rules.txt an internal data file #858

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

nedley
Copy link
Contributor

@nedley nedley commented Jun 6, 2024

Fix #853

@nedley nedley requested a review from macchiati June 6, 2024 17:13
@nedley nedley force-pushed the ned/internal-emoji-ordering-rules branch from df79a2e to dd84812 Compare June 6, 2024 17:13
@markusicu
Copy link
Member

CI failure --> please mvn spotless:apply

Will there be changes on the CLDR side as well? Updating the docs, removing this file from there, ...?

@nedley
Copy link
Contributor Author

nedley commented Jun 6, 2024

Will there be changes on the CLDR side as well? Updating the docs, removing this file from there, ...?

@macchiati will have to answer, I am doing his bidding here.

@nedley nedley requested review from echeran and josh-hadley June 11, 2024 19:35
@josh-hadley josh-hadley changed the title Make emoji-ordering-rules.txt an internal data file (#853) Make emoji-ordering-rules.txt an internal data file Jun 25, 2024
Copy link
Collaborator

@josh-hadley josh-hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@nedley nedley merged commit ac73480 into main Jun 25, 2024
20 checks passed
@nedley nedley deleted the ned/internal-emoji-ordering-rules branch June 25, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simpler/robuster update of CLDR emoji (emoji-ordering-rules.txt)
3 participants