Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propertywise … AreAlike #842

Merged
merged 20 commits into from
May 31, 2024
Merged

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented May 31, 2024

Towards #575. Does not fix it; while should address the use case for PAG review of proposals, only convenient for people who know how to wield the tools—and specifically the invariant tests—, and that is a very small number of people indeed. I should build something in a similar vein in the JSPs.

See a sample test failure in https://github.com/unicode-org/unicodetools/pull/842/files/3d97c4a4a9bc806c65dc70722e0d947dec826edd#diff-f86c50974502e26e45f2495660a5406f44604ae6ce4c49329e45a795bd520a9a.

@eggrobin eggrobin requested review from macchiati and markusicu May 31, 2024 15:38
@markusicu markusicu requested a review from echeran May 31, 2024 16:49
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx

@eggrobin eggrobin merged commit 263c3aa into unicode-org:main May 31, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants