-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propertywise … AreAlike #842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Markus Scherer <[email protected]>
…parison test fails This reverts commit af5b2d9.
… new comparison test fails" This reverts commit 04cc2b0.
markusicu
reviewed
May 31, 2024
unicodetools/src/main/java/org/unicode/text/UCD/TestUnicodeInvariants.java
Outdated
Show resolved
Hide resolved
unicodetools/src/main/java/org/unicode/text/UCD/TestUnicodeInvariants.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Markus Scherer <[email protected]>
markusicu
approved these changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm tnx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #575. Does not fix it; while should address the use case for PAG review of proposals, only convenient for people who know how to wield the tools—and specifically the invariant tests—, and that is a very small number of people indeed. I should build something in a similar vein in the JSPs.
See a sample test failure in https://github.com/unicode-org/unicodetools/pull/842/files/3d97c4a4a9bc806c65dc70722e0d947dec826edd#diff-f86c50974502e26e45f2495660a5406f44604ae6ce4c49329e45a795bd520a9a.