IdnaTestV2: V4..V6 -> V5..V7, check new V4, escape empty #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
changed the title
markusicu
changed the title
markusicu
requested review from
echeran,
Manishearth,
macchiati,
asmusf,
josh-hadley and
Ken-Whistler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed one commit at a time:
https://www.unicode.org/reports/tr46/#Validity_Criteria
V4 was inserted in Unicode 15.1.
Move V4..V6 to V5..V7 so that the test data error numbers match the spec again.
Then add code and an explicit test case to check the new V4 criterion.
Also, fix
[164-A50] Action Item for Markus Scherer: Revise the syntax of IdnaTestV2.txt, adding the ability to represent an explicitly empty input or output string; and generate a new version of the data accordingly, for Unicode version 14.0.
Also, add a test case for
[172-A102] Action Item for Markus Scherer, Mark Davis, PAG: Investigate the report in L2/22-124 item IDNA1. If necessary, propose a clarification of UTS #46, and/or update the code that generates the IdnaTestV2.txt file.