Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Unicode 16 linebreaking changes #801

Merged
merged 3 commits into from
May 3, 2024

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented May 3, 2024

I had missed this one in #798 because we were missing a LineBreakTest.txt action item for it:

[179-C25] Consensus: In UAX #14, change rule LB21a from HL (HY | BA) × to HL (HY | BA) × [^HL] (do not break after the hyphen in Hebrew-hyphen-non-Hebrew) to match the rationale for adding LB21a given in L2/11-141R. For Unicode Version 16.0. See document L2/24-064 item 5.2.

@eggrobin eggrobin requested a review from markusicu May 3, 2024 13:15
@eggrobin
Copy link
Member Author

eggrobin commented May 3, 2024

Note: running the ICU rbbi/RBBITest/TestUnicodeFiles on the current unicodetools LineBreakTest.txt (patched to replace U+1B50 with U+1BC0 since ICU does not yet have its LB change UTC-177-C46) on my uax14-integration branch failed with

         Test file "LineBreakTest.txt", line 16664, unexpected break found at position 2
         Expected : ×א×-÷א÷
         Actual   : ×א÷-÷א÷

So our conformance tests would have caught that blunder during ICU integration.

With the LineBreakTest.txt from this branch (similarly patched) the ICU test now passes.

Note that this all passes after removing the exemptions for ICU-21097, so this one can be closed soon (with the resolution that Andy had predicted four years ago).

@eggrobin eggrobin merged commit 2e1d932 into unicode-org:main May 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants