U+0300 and U+0308 from L2/23-280 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
reviewed
Mar 22, 2024
Comment on lines
+529
to
+531
| {"\u0300", Status.COMMON}, | ||
| {"a\u0300", Status.SAME, Status.COMMON, Status.OTHER}, | ||
| {"ä", Status.SAME, Status.COMMON, Status.OTHER}, | ||
| {"ä", Status.SAME, Status.OTHER}, |
There was a problem hiding this comment.
I haven't looked at what these expected values are, but (a) I assume these do naturally fall out from the data changes and (b) I believe that whole-script confusables haven been put on ice until someone can figure out real use cases, so this probably does not matter a lot.
FYI @macchiati
markusicu
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix the bad tests. Also add some tests to cover the combinations no longer covered by the combining marks.
See https://github.com/unicode-org/properties/issues/256.
[179-C] Consensus: Add all 53 entries to ScriptExtensions.txt as proposed in document L2/23-280, including U+0300 and U+0308, for Unicode Version 16.0. See document L2/24-064 item 2.3. This decision supersedes consensus UTC-178-C39.