-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign Sentence_Terminal and Terminal_Punctuation for 16.0 characters #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusicu
previously approved these changes
Apr 30, 2024
markusicu
previously approved these changes
Apr 30, 2024
@eggrobin remember to dust up this older PR |
markusicu
approved these changes
May 6, 2024
@eggrobin I just noticed that this commit added unicodetools/data/ucd/dev/Zaghawa-proposal2024-01-26b.pdf -- I probably overlooked it because it only shows as one line in the diff -- this was unintentional, wasn't it? |
Oops. Very unintentional indeed. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining 16.0 punctuation characters mostly do not look terminal:
U+10D6E GARAY HYPHEN
U+113D7 TULU-TIGALARI SIGN OM PUSHPIKA
U+113D8 TULU-TIGALARI SIGN SHRII PUSHPIKA
U+11BE1 SUNUWAR SIGN PVO
These two are abbreviation marks; clearly not Sentence_Terminal; we are inconsistent as to whether those are Terminal_Punctuation, but heavily leaning towards No (filed https://github.com/unicode-org/properties/issues/246).
U+16D6D KIRAT RAI SIGN YUPI
U+1E5FF OL ONAL ABBREVIATION SIGN